Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

to_python(n_evaluation=True)-> eval_N(...).to_python() #640

Merged
merged 6 commits into from
Jul 9, 2023
Merged

to_python(n_evaluation=True)-> eval_N(...).to_python() #640

merged 6 commits into from
Jul 9, 2023

Conversation

mmatera
Copy link
Contributor

@mmatera mmatera commented Nov 21, 2022 •
edited by gitpod-io bot
Loading

Following the comment #559 (comment) this is the part that is the not-polemic part of #559

TiagoCavalcante
TiagoCavalcante approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@TiagoCavalcante TiagoCavalcante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rocky
Copy link
Member

rocky commented Jul 9, 2023

This is okay for merging - what was holding it back?

@mmatera mmatera merged commit 91aa07b into master Jul 9, 2023
11 checks passed
@mmatera mmatera deleted the removing_case_of_n_evaluation branch July 9, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TiagoCavalcante TiagoCavalcante TiagoCavalcante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmatera @rocky @TiagoCavalcante